Just a big swivel bench vise has been my choice for the last 45+yrs. A set or two of wooden safety jaws is a must of course. One set flat,,one V notched is about all you need.
When they wear out,,and they do if you do enough work, make another set
Extra padding when handling delicate finished items.
If you reload shotshells or know someone that does, save the canvas shot bags,,they make nice padding.
Smooth surface on the steel vise jaws themselves,,you don't want the type w/the teeth in them .
The big plain swivel bench vise on a solid mounting gets my vote.
Nothing fancy.
One shop I worked in had Versa Vises set up at all the benches. They were OK for light weight jobs and cleaning chores, but I didn't care for them for regular gunsmithing work. Too much vibration when working .
I guess it depends on what you have in mind to do.
JMO and experience...
